Configure logger in the Environment #1452

t0bst4r · 2024-11-27T23:17:01Z

t0bst4r
Nov 27, 2024

I know this would require some larger refactoring but I’d like to be able to configure the logger using the environment. If every class & service would get its logger like this, we could easily intercept, group or split logs.

My use case: my app can have multiple server nodes / bridges. By creating a new environment per server node (using the default env as parent) I could write the logs of each bridge to a different log file, or colorize them differently or capture them per bridge to show it in the Frontend… I think there could be a lot more use cases.

class LoggerService {
  createLogger(): Logger;
}

class MyFileLogger extends LoggerService {
  // create a file logger etc. 
}

const env = Environment.default; // with default logger

const envA = new Environment("env-a", env);
envA.set(LoggerService, new MyFileLogger("file-a"));
const nodeA = await ServerNode.create({ 
  environment: envA
});

const envB = new Environment("env-b", env);
envB.set(LoggerService, new MyFileLogger("file-b"));
const nodeB = await ServerNode.create({ 
  environment: envB
});

lauckhart · 2024-11-28T18:39:25Z

lauckhart
Nov 28, 2024

Agreed this would be nice.

Looks like there are roughly 150 places we'd need to move away from loggers obtained from the global singleton. Refactoring would be a mix of "create new logger for this instance" and "use caller-supplied logger". So non-trivial editorial decisions for each location and would touch many lines.

To mitigate though we could do in passes... And roughly 10% of locations are in deprecated code paths so that helps a bit.

Not sure when this would bubble to top of priority list w/ current resources but I'd be happy to help out if someone decides to take on before I get to it.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure logger in the Environment #1452

Uh oh!

{{title}}

Uh oh!

Replies: 1 comment

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Configure logger in the Environment #1452

Uh oh!

t0bst4r Nov 27, 2024

Replies: 1 comment

Uh oh!

lauckhart Nov 28, 2024

t0bst4r
Nov 27, 2024

lauckhart
Nov 28, 2024