fix(ble): silence noble disconnect-race rejections during unsubscribe (#3670)

Apollon77 · claude · web-flow · commit 32affcdf8bc4 · 2026-04-28T16:43:36.000+02:00
When the BLE peripheral disconnects while a C2 unsubscribe (or final
disconnect) call is in flight, noble rejects the pending operation with
"Disconnected &lt;N&gt;". The previous code logged this as a real error even
though it is the expected outcome of a normal disconnect race and the
unsubscribe is moot once the link is gone.

- Handshake-timeout path now skips the unsubscribe entirely when the
  peripheral is no longer connected, and treats noble disconnect errors
  as silent.
- BTP-close-callback unsubscribe and the close() disconnect catch use
  the same isNobleDisconnectError filter so genuine errors still surface
  while race-rejections do not.

Co-authored-by: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/nodejs-ble/src/NobleBleChannel.ts b/packages/nodejs-ble/src/NobleBleChannel.ts
@@ -502,9 +502,13 @@ export class NobleBleChannel extends BleChannel<Bytes> {
         const btpHandshakeTimeout = Time.getTimer("BLE handshake timeout", MatterBle.BTP_CONN_RSP_TIMEOUT, async () => {
             characteristicC2ForSubscribe.removeListener("data", handshakeHandler);
 
-            await characteristicC2ForSubscribe
-                .unsubscribeAsync()
-                .catch(error => logger.error(`Peripheral ${peripheralAddress}: Error while unsubscribing`, error));
+            if (peripheral.state === "connected") {
+                await characteristicC2ForSubscribe.unsubscribeAsync().catch(error => {
+                    if (!isNobleDisconnectError(error)) {
+                        logger.error(`Peripheral ${peripheralAddress}: Error while unsubscribing`, error);
+                    }
+                });
+            }
 
             logger.debug(
                 `Peripheral ${peripheralAddress}: Handshake Response not received. Disconnect from peripheral`,
@@ -560,14 +564,13 @@ export class NobleBleChannel extends BleChannel<Bytes> {
             async () => {
                 if (peripheral.state !== "connected" || !nobleChannel.connected) return;
                 logger.debug(`Peripheral ${peripheralAddress}: Disconnect from peripheral because btp session closed`);
-                // Unsubscribe from C2 notifications, then disconnect.  If unsubscribe fails (e.g. the
-                // peripheral already started disconnecting and Noble's _withDisconnectHandler rejected the
-                // pending operation with "Disconnected unknown"), proceed to disconnectAsync anyway.
                 characteristicC2ForSubscribe
                     .unsubscribeAsync()
-                    .catch(error =>
-                        logger.debug(`Peripheral ${peripheralAddress}: Error while unsubscribing from C2`, error),
-                    )
+                    .catch(error => {
+                        if (!isNobleDisconnectError(error)) {
+                            logger.debug(`Peripheral ${peripheralAddress}: Error while unsubscribing from C2`, error);
+                        }
+                    })
                     .then(() => {
                         if (peripheral.state !== "connected") {
                             return;
@@ -663,11 +666,11 @@ export class NobleBleChannel extends BleChannel<Bytes> {
         this.#cleanupDataListener();
         await this.btpSession.close();
         if (this.connected) {
-            this.peripheral
-                .disconnectAsync()
-                .catch(error =>
-                    logger.error(`Peripheral ${this.peripheral.address}: Error while disconnecting`, error),
-                );
+            this.peripheral.disconnectAsync().catch(error => {
+                if (!isNobleDisconnectError(error)) {
+                    logger.error(`Peripheral ${this.peripheral.address}: Error while disconnecting`, error);
+                }
+            });
         }
         this.emitClosed();
     }
