fix(commissioner): extend operational connect timeout to 4m15s#3674
Merged
fix(commissioner): extend operational connect timeout to 4m15s#3674
Conversation
Several commissioning steps allow up to ~2 minute server-side delays. The previous 4 minute CASE connect timeout left too little headroom in back-to-back delay scenarios. Bumping to 255 seconds keeps us safely inside the 5 minute failsafe re-arm and matches observed worst-case peer behavior. Failsafe reset on operational connect failure already fires through the existing CommissioningError catch path.
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the operational CASE connect timeout during commissioning in ControllerCommissioner to better accommodate slower commissionee-side transitions while still staying within the failsafe re-arm window.
Changes:
- Replace the operational
peer.connecttimeout fromMinutes(4)toSeconds(255)(4m15s). - Remove the now-unused
Minutesimport.
Two ~2-minute server-side retry windows fit within 4m15s before we abort the operational connect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ControllerCommissionerfromMinutes(4)toSeconds(255)(4m15s) so commissioning steps that trigger up to ~2 minute server-side delays still have headroom before we abort the connect.CASE_RECONNECT_TIMEOUT).armFailSafe expiryLengthSeconds=0while PASE is still alive) already fires through the existingCommissioningErrorcatch path inControllerCommissioningFlow.executeCommissioning— verified in production logs (operative-connection-failed → immediatearmFailSafeinvoke withexpiryLengthSeconds: 0).Test plan
OperativeConnectionFailedErrorthrown andarmFailSafe(0)still invoked over PASE before peer cleanup.🤖 Generated with Claude Code