chore(node): remove stale generated tag files orphaned by Common* rename#3689
Merged
chore(node): remove stale generated tag files orphaned by Common* rename#3689
Conversation
Codegen for Matter 1.5.1 renamed several namespace tag exports by prefixing them with `Common` (e.g. `AreaNamespaceTag` → `CommonAreaNamespaceTag`). The new files were generated and the index barrel was updated, but the old files were left behind on disk — unexported and unused, but still present. Remove the 10 orphan files in `packages/node/src/tags/`: - AreaNamespaceTag.ts - CompassDirectionTag.ts - CompassLocationTag.ts - DirectionTag.ts - LandmarkNamespaceTag.ts - LevelTag.ts - LocationTag.ts - NumberTag.ts - PositionTag.ts - RelativePositionTag.ts Verified via repo-wide search: no `import` or `export` references the bare (non-`Common`-prefixed) names. Build, format-verify, and full node test suite (988 tests) pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up @matter/node’s generated semantic tag namespace sources by removing stale, unreferenced tag files that were left behind after the Common* rename (e.g. PositionTag → CommonPositionTag), keeping packages/node/src/tags/ aligned with what is actually exported and used.
Changes:
- Removed 10 orphaned generated tag namespace files in
packages/node/src/tags/that haveCommon*replacements. - Kept the tags barrel aligned with the
Common*exports (verifiedpackages/node/src/tags/index.tsexportsCommon*files). - Verified via repo search that the removed symbol names are not imported anywhere (no
import { XTag } ...usages found).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/node/src/tags/AreaNamespaceTag.ts | Removed stale generated tag namespace file (superseded by CommonAreaNamespaceTag). |
| packages/node/src/tags/CompassDirectionTag.ts | Removed stale generated tag namespace file (superseded by CommonCompassDirectionTag). |
| packages/node/src/tags/CompassLocationTag.ts | Removed stale generated tag namespace file (superseded by CommonCompassLocationTag). |
| packages/node/src/tags/DirectionTag.ts | Removed stale generated tag namespace file (superseded by CommonDirectionTag). |
| packages/node/src/tags/LandmarkNamespaceTag.ts | Removed stale generated tag namespace file (superseded by CommonLandmarkNamespaceTag). |
| packages/node/src/tags/LevelTag.ts | Removed stale generated tag namespace file (superseded by CommonLevelTag). |
| packages/node/src/tags/LocationTag.ts | Removed stale generated tag namespace file (superseded by CommonLocationTag). |
| packages/node/src/tags/NumberTag.ts | Removed stale generated tag namespace file (superseded by CommonNumberTag). |
| packages/node/src/tags/PositionTag.ts | Removed stale generated tag namespace file (superseded by CommonPositionTag). |
| packages/node/src/tags/RelativePositionTag.ts | Removed stale generated tag namespace file (superseded by CommonRelativePositionTag). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Common(e.g.AreaNamespaceTag→CommonAreaNamespaceTag). The new files were generated andpackages/node/src/tags/index.tswas updated, but the old files were left behind on disk — unexported and unreferenced.packages/node/src/tags/.Files removed
AreaNamespaceTag.tsCompassDirectionTag.tsCompassLocationTag.tsDirectionTag.tsLandmarkNamespaceTag.tsLevelTag.tsLocationTag.tsNumberTag.tsPositionTag.tsRelativePositionTag.tsVerified via repo-wide search: no
importorexportreferences the bare (non-Common-prefixed) symbol names anywhere in the codebase. Each has aCommon*counterpart that IS exported from the index barrel.🤖 Generated with Claude Code