Skip to content

Commit 43d0df6

Browse files
Apollon77claude
andauthored
fix(codegen): alias FieldSchema.id to "fieldid" for command param tables (#3692)
Matter 1.5.1 AudioOutput cluster spec uses "Field ID" column header in SelectOutput and RenameOutput parameter tables. Header normalizes to column key "fieldid", but FieldSchema.id was bare Integer with no alias, so the lookup failed and both commands generated with no parameters. Add "fieldid" alias so the parser recognizes that header. Regenerated intermediate spec and standard model — AudioOutput SelectOutput now has Index and RenameOutput has Index + Name as the spec defines. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 98ffc5c commit 43d0df6

5 files changed

Lines changed: 84 additions & 24 deletions

File tree

packages/model/src/standard/elements/audio-output.element.ts

Lines changed: 9 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/model/src/standard/resources/audio-output.resource.ts

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/types/src/clusters/audio-output.d.ts

Lines changed: 36 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

support/codegen/src/mom/spec/translate-datatype.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ function hasColumn(definition: SpecReference, ...names: string[]) {
134134
}
135135

136136
const FieldSchema = {
137-
id: Integer,
137+
id: Alias(Integer, "fieldid"),
138138
name: Alias(Identifier, "field"),
139139

140140
// Not really optional, but we want to process rows even if missing

support/models/src/v1.5.1/spec.ts

Lines changed: 31 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)